Bugzilla – Bug 4150
do not use break in Perl, use last
Last modified: 2006-06-27 16:39:17
You need to
before you can comment on or make changes to this bug.
You may want to sanity check Perl modules in the CVS for the job manager:
# perl -I$GLOBUS_LOCATION/lib/perl -w -c condor.pm
Unquoted string "break" may clash with future reserved word at condor.pm line 51.
Useless use of a constant in void context at condor.pm line 51.
// should probably be written as "" at condor.pm line 327.
Name "Globus::GRAM::JobManager::condor::Config" used only once: possible typo at
condor.pm line 166.
Name "Globus::GRAM::JobManager::condor::library_string" used only once: possible
typo at condor.pm line 180.
condor.pm syntax OK
 don't use "break" in Perl, use "last". The loop will not prematurely exit,
as Perl will ignore the unknown bare word. It does not look harmful, but then, I
didn't write the loop.
 You may want to check out substr( $^O, 0, 4 ) eq 'irix' instead of "use
Config", if all you do is checking if the OS is irix.
 library_string is suspicous - where is it declared or initialized. Perl may
use the empty string or undef every time here.
Committed fixes to this to CVS trunk.