Bug 2853 – find-condor-tools has bug in architecture detection

Bug 2853 - find-condor-tools has bug in architecture detection

Summary:

find-condor-tools has bug in architecture detection

Status:	RESOLVED FIXED

Product:	GRAM
Component:	gt2 Gatekeeper/Jobmanager
Version:	3.9.5
Platform:	IA64 Linux

Importance:	P3 normal
Target Milestone:	4.0
Assigned To:	Joe Bester

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-03-03 11:39 by Alain Roy
Modified:	2005-03-18 17:01 (History)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Alain Roy 2005-03-03 11:39:26

Find condor-tools will report the architecture as "no" if it doesn't recognize
the architecture. We have users that install on ia64 and x86_64, so it fails for
them. 

This bug is present in both Globus 3.2.1 and Globus 3.9.5, as best I can tell. 

Here is a patch to fix the problem:

--- find-condor-tools.orig      Wed Mar  2 15:51:41 2005
+++ find-condor-tools.in        Wed Mar  2 15:54:17 2005
@@ -76,6 +76,12 @@
         i?86*:*:*)
          CONDOR_ARCH=INTEL
          ;;
+        ia64:*:*)
+         CONDOR_ARCH=IA64
+         ;;
+        x86_64:*:*)
+         CONDOR_ARCH=x86_64
+         ;;
         sun4*:*:*)
          CONDOR_ARCH=`uname -m | tr '[a-z]' '[A-Z]'`
          ;;

An even better idea would be to have the jobmanager perl script not insert the
architecture if it doesn't know what it should be. This should be an easy patch
(check if the architecture is "no"), but I didn't try it out. 

Thanks,
-alain

------- Comment #1 From Joe Bester 2005-03-04 15:56:07 -------

Patch committed to CVS trunk. Replaced AC_MSG_WARN with AC_MSG_ERROR when the 
arch/os can't be figured out as those are fatal to GRAM.

------- Comment #2 From Charles Bacon 2005-03-18 10:59:07 -------

via email:
It shouldn't be fatal but instead GRAM simply shouldn't fill in the
architecture and OS when it can't figure them out, because Condor will
fill them in correctly. This feature (filling in the arch/os) is only
needed when people want to have a jobmanager on one arch/os that can
submit to a different arch/os. This is rare.

------- Comment #3 From Jaime Frey 2005-03-18 17:01:41 -------

Agreed. I don't think the architecture-detection code in find-condor-tools is
needed. If ARCH/OPSYS aren't specified in the requirements expression in the
condor submit file, condor will add them automatically to match the local
machine. So in the default case, condor_arch and condor_os wouldn't be defined
in the jobmanager setup and the submit perl routine wouldn't add them to the job
requirements expression. Admins that want cross-platforms submits configure
jobmanagers with condor_arch and condor_os set to the proper target platform and
the submit routine includes them in the requirements expression.