Bug 1534 - LIST commands shouldn't use active connections
: LIST commands shouldn't use active connections
Status: RESOLVED FIXED
: GridFTP
GridFTP
: 2.0
: PC All
: P2 normal
: ---
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2004-02-11 17:48 by
Modified: 2004-02-12 09:28 (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2004-02-11 17:48:59
This bug fix was given to the VDT by EDG. It was created by Cal Loomis. It is 
for Globus 2.4.3.

He describes it as: "Do not use an active connection for LIST commands, 
because it would cause unnecessary failures in a firewalled environment."

Here is the patch:

--- 
globus_2_4_3_adv2003_fix892_fix956/gridftp/client/source/globus_ftp_client_stat
e.c  Fri Jan 10 17:08:23 2003
+++ 
globus_2_4_3_adv2003_fix892_fix956_more/gridftp/client/source/globus_ftp_client
_state.c     Mon Dec  8 21:15:50 2003
@@ -1440,7 +1440,16 @@
        {
            globus_assert(client_handle->state ==
                          GLOBUS_FTP_CLIENT_HANDLE_SOURCE_SETUP_CONNECTION);
+#if 0
            target->state = GLOBUS_FTP_CLIENT_TARGET_SETUP_PORT;
+#else
+           /*
+            * Do _NOT_ use an active connection, because it would cause
+            * unnecessary failures in a firewalled environment...
+            */
+
+           target->state = GLOBUS_FTP_CLIENT_TARGET_SETUP_PASV;
+#endif
        }
        /* Prefer PASV data connections for most operations */
        else if(client_handle->state ==

This patch has been used extensively, so we're not worried about its 
correctness.
------- Comment #1 From 2004-02-11 18:14:06 -------
This has actually already been changed and should have been out with 3.2 alpha, 
but it's definitely in 3.2beta (coming soon).

Joe