Bug 1483 - Objects disappearing in MDS (bug 956 reopened)
: Objects disappearing in MDS (bug 956 reopened)
Status: RESOLVED FIXED
: MDS2
gt2_mds
: unspecified
: PC Linux
: P2 blocker
: ---
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2004-01-05 15:47 by
Modified: 2005-12-06 16:59 (History)


Attachments
proper patch for bug 956 (2.32 KB, patch)
2004-01-05 15:49, Maarten Litmaath
Details
patch for openldap-2.0.22-patch (19.05 KB, patch)
2004-01-05 15:51, Maarten Litmaath
Details
patch for grid-info-soft-register (1023 bytes, patch)
2004-01-05 15:54, Maarten Litmaath
Details


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2004-01-05 15:47:36
In mds/openldap/ldapmodules/search.c with tag globus_2_4_3 I see the following
on lines 422-427 (indentation reduced for clarity):

-----------------------------------------------------------------------------
                errno = 0;
                while (errno == EINTR)
                        rc = select (fdn + 1, &readfds, NULL, &readfds, &tv);


                if (rc < errno) 
-----------------------------------------------------------------------------

Surely this code does not do what was intended (the select() is never done);
also the comparison of "rc" with "errno" is bad style at the very least.

I propose this to be fixed by applying the first patch attached below.
Note that it also ensures the variable "data1" is always initialized.
A similar patch was applied by LCG on top of MDS 2.2 and found to work OK.

I have added two more patches by NorduGrid/LCG, that fix various
OpenLDAP bugs and misfeatures affecting the stability of the MDS.
------- Comment #1 From 2004-01-05 15:49:41 -------
Created an attachment (id=284) [details]
proper patch for bug 956
------- Comment #2 From 2004-01-05 15:51:03 -------
Created an attachment (id=285) [details]
patch for openldap-2.0.22-patch
------- Comment #3 From 2004-01-05 15:54:47 -------
Created an attachment (id=286) [details]
patch for grid-info-soft-register

This patch introduces a timeout parameter, which is accepted when
the above patch for openldap-2.0.22-patch has been applied before.
------- Comment #4 From 2004-01-12 13:11:36 -------
Thanks for the contributions.  I'm currently testing the patched code with a 
third party.  An update package will be provided on the Globus Advisory page.
------- Comment #5 From 2004-01-15 13:15:57 -------
An update package for the GRIS has been posted on the Globus advisory page as 
of 1/14
------- Comment #6 From 2004-01-26 03:08:27 -------
Thanks for your efforts here.  I note that the 3 patches have been put
into the globus_2_4_branch, but *not* into the head of the CVS trunk:
is that OK?
------- Comment #7 From 2004-01-26 16:08:25 -------
i'll be commiting to the CVS trunk as soon as I finish some related work.  
Thanks for the notice.   
------- Comment #8 From 2004-01-30 09:29:41 -------
Just to be sure, the changes should be committed in time
before the upcoming 3.2 tag is made!  Thanks!