Bug 4512 – rls query returns incomplete result on 64bit system (patch available)

Bug 4512 - rls query returns incomplete result on 64bit system (patch available)

Summary:

rls query returns incomplete result on 64bit system (patch available)

Status:	RESOLVED FIXED

Product:	Replica Location
Component:	RLS
Version:	development
Platform:	PC Linux

Importance:	P3 normal
Target Milestone:	---
Assigned To:	Rob S

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-06-14 11:53 by Pavel Shramov
Modified:	2009-12-07 16:24 (History)

Attachments
SQLLEN fix (4.58 KB, patch) 2006-06-14 11:58, Pavel Shramov	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Pavel Shramov 2006-06-14 11:53:06

In query_ret2 function at db.c:2064 SQLFetch fills only first of 2 buffers
bound
using SQLBindCol

Compilation warnings:
db.c: In function `query_ret2':
db.c:2078: warning: passing arg 6 of `SQLBindCol' from incompatible pointer
type
db.c:2080: warning: passing arg 6 of `SQLBindCol' from incompatible pointer
type

In /usr/include/sql.h SQLBindCol is declared with SQLLEN * argument but in rls
SQLINTEGER * is given.

On 64bit system SQLLEN and SQLINTEGER have 64 and 32 bits respectively.

Provided patch fixes local variable declarations for len parameter.
Similar problem with SQLRowCount fixed too.

db.c:1557: warning: passing arg 2 of `SQLRowCount' from incompatible pointer
type
db.c:1578: warning: passing arg 2 of `SQLRowCount' from incompatible pointer
type


Output of globus-rls-client
rls> clear
rls> create lfile pfile
rls> query lrc lfn lfile
  lfile: 
rls>

on 32 bit systems (or with patch applied)
rls> clear
rls> create lfile pfile
rls> query lrc lfn lfile
  lfile: pfile
rls>

arch: x86-64
iodbc: 3.52.2-3 (debian)
SQL backend: postgre 7.4.7

------- Comment #1 From Pavel Shramov 2006-06-14 11:58:00 -------

Created an attachment (id=981) [details]
SQLLEN fix

------- Comment #2 From Rob S 2006-06-14 18:06:06 -------

This is excellent! Thanks for identifying the problem AND proving a patch.

I have tested it out myself with RLS using:
-- libiodbc-3.52.4
-- unixODBC-2.2.11

I was hoping to get this committed and rolled into the GT 4.1 development
release, unfortunately it may not get committed that quick. What I have found
is that the older libiodbc-3.51.x does not define SQLLEN. So far we have been
advising libiodbc users to use libiodbc-3.51.2 because psqlodbc will not build
with their newer libs because of an API redefinition.

So this may take us a while to sort things out and it may not make it into this
month's 4.1 release. But we'll make sure users know about it until we can
commit it.