Bug 3795 - jobmanager perl modules issues
: jobmanager perl modules issues
Status: RESOLVED FIXED
: GRAM
gt2 Gatekeeper/Jobmanager
: 4.0.0
: All All
: P3 enhancement
: ---
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2005-09-30 17:30 by
Modified: 2011-12-14 08:01 (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2005-09-30 17:30:17
The $GL/lib/perl/Globus/GRAM/JobManager/*.pm modules should be run by some
developer through "perl -w -c ..." to check for troubles. I am seeing with a
fairly recent pre-WS GT4 check-out plenty of things like: 

Unquoted string "break" may clash with future reserved word at
/opt/globus/latest/lib/perl/Globus/GRAM/JobManager/condor.pm line 51.
Useless use of a constant in void context at
/opt/globus/latest/lib/perl/Globus/GRAM/JobManager/condor.pm line 51.
// should probably be written as "" at
/opt/globus/latest/lib/perl/Globus/GRAM/JobManager/condor.pm line 330.

when invoking the condor.pm module from the grid monitor (manually). I am sure
we can find similar things in other batch jobmanager modules. 

As for the condor.pm module: 

o "break" is the wrong language; the Perl word is "last". 
o the // should really be '' in the join.
o The escape/quoting in lines 209-213 does not match Condor's requirements. This
will produce broken jobs (bug#3706). Ask Jaime for what Condor needs.
------- Comment #1 From 2011-12-14 08:01:15 -------
I think these have all been resolved in the 5.x branches.