<?xml version="1.0" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugzilla.globus.org/bugzilla/bugzilla.dtd">

<bugzilla version="3.2.3"
          urlbase="http://bugzilla.globus.org/bugzilla/"
          maintainer="bacon@mcs.anl.gov"
>

    <bug>
          <bug_id>4281</bug_id>
          
          <creation_ts>2006-03-11 16:18</creation_ts>
          <short_desc>update to IdP metadata template</short_desc>
          <delta_ts>2008-04-25 21:12:09</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>GridShib</product>
          <component>Shibboleth IdP Plugin</component>
          <version>0.4.4</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          
          <priority>P3</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>beta</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Freeman">tfreeman@mcs.anl.gov</reporter>
          <assigned_to name="Tom Scavo">trscavo@gmail.com</assigned_to>
          <cc>gridshib-dev@globus.org</cc>
    
    <cc>tfreeman@mcs.anl.gov</cc>
    
    <cc>vwelch@uiuc.edu</cc>

      

      
          <long_desc isprivate="0">
            <who name="Tim Freeman">tfreeman@mcs.anl.gov</who>
            <bug_when>2006-03-11 16:18:12</bug_when>
            <thetext>The sample metadata template in the NameMapper plugin:

gridshib/idp/data/gridshib-idp-metadata-template.xml

.. has this comment:

        Zero or more saml:Attribute elements are included here.
        (Since these elements are currently not used by grid
        service providers, they are more for documentation purposes
        than anything else.) 

Now that the GT module is aware of Attribute elements, this parenthetical remark
should be updated or deleted.  

I&apos;ll post a link here to the relevant documentation once it is online.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who name="Tom Scavo">trscavo@gmail.com</who>
            <bug_when>2006-03-12 11:17:58</bug_when>
            <thetext>I&apos;ve read the documentation:

http://gridshib.globus.org/docs/admin-index.html#metadata-attr-optimization

I agree this is a useful optimization provided the following are true:

1. It is OFF by default (which evidently it is).
2. If it is ON and there are no Attribute elements in the IdP metadata, the
optimization is short-circuited (i.e., the query proceeds).

I recommend the comment be changed as follows:

        Zero or more saml:Attribute elements are included here.
        A Grid service provider may choose not to query the AA 
        based on the attributes in this list, therefore this list 
        MUST be comprehensive.  Since no method of dynamic metadata
        exchange currently exists, it is recommended that IdPs
        omit this list entirely.

At least two things are needed before we can recommend otherwise:

- A tool that produces IdP metadata from the underlying IdP configuration
- A simple method of publishing IdP metadata

</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who name="Tim Freeman">tfreeman@mcs.anl.gov</who>
            <bug_when>2006-03-12 11:45:29</bug_when>
            <thetext>OK, makes sense.  I just verified that your point #2 is in the code, the
optimization treats 0 attributes as a signal to NOT disable the query.  Your new
comment text looks good to me, thanks. 

</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who name="Tom Scavo">trscavo@gmail.com</who>
            <bug_when>2006-03-12 14:16:04</bug_when>
            <thetext>The comment in the IdP metadata template has been modified in my sandbox.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who name="Tom Scavo">trscavo@gmail.com</who>
            <bug_when>2006-05-24 11:15:20</bug_when>
            <thetext>The updated IdP metadata template has been committed to CVS.</thetext>
          </long_desc>
      
      

    </bug>

</bugzilla>